Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the description #529

Merged
merged 1 commit into from
Aug 1, 2023
Merged

modify the description #529

merged 1 commit into from
Aug 1, 2023

Conversation

jhonroxton
Copy link
Contributor

chang code:
Description: "this is the example collection for inser and search"
to:
Description: "this is the example collection for insert and search"

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 July 31, 2023 08:50
@sre-ci-robot
Copy link

Welcome @jhonroxton! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 31, 2023
@jhonroxton
Copy link
Contributor Author

/assign @congqixia

@congqixia
Copy link
Contributor

@jhonroxton thanks for the contribution, could you please fix the DCo issue?

Signed-off-by: jhonroxton <2505814930@qq.com>
@jhonroxton
Copy link
Contributor Author

@jhonroxton thanks for the contribution, could you please fix the DCo issue?

@congqixia ok

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind improvement
/lgtm

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me labels Aug 1, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jhonroxton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Aug 1, 2023
@congqixia congqixia added the ci-passed auto merge needed label label Aug 1, 2023
@sre-ci-robot sre-ci-robot merged commit 1d5c182 into milvus-io:master Aug 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants